Skip to content

Support custom chain ids#429

Merged
ManuelBilbao merged 4 commits intoCommit-Boost:mainfrom
eth-fabric:custom-chainid
Mar 2, 2026
Merged

Support custom chain ids#429
ManuelBilbao merged 4 commits intoCommit-Boost:mainfrom
eth-fabric:custom-chainid

Conversation

@JasonVranek
Copy link
Copy Markdown
Collaborator

Currently there is no way to specify a chain id for the Custom variant of the Chain enum. This will make it difficult to test Commit-Boost on a non-standard chain (i.e., a local Kurtosis instance) once functions like compute_prop_commit_signing_root() are merged in.

This PR adds a chain_id: u64 to the Chain::Custom enum variant. It also closes #419 and fixes broken PBS config tests from previous PRs.

Comment thread crates/common/src/types.rs Outdated
Comment thread crates/common/src/types.rs
Comment thread config.example.toml Outdated
@ManuelBilbao ManuelBilbao merged commit e023016 into Commit-Boost:main Mar 2, 2026
2 checks passed
@JasonVranek JasonVranek deleted the custom-chainid branch March 2, 2026 19:15
JasonVranek added a commit to JasonVranek/commit-boost-client that referenced this pull request Apr 29, 2026
* PBS: Reload the config file when it changes (Commit-Boost#409)

* ssv-network: SSV-node API support (Commit-Boost#415)

Co-authored-by: Joe Clapis <jclapis@outlook.com>

* fix(tests): update tests for SSV API rename and PbsState signature change (Commit-Boost#427)

* Fix broken CLI caused by double-parse bug (Commit-Boost#428)

Co-authored-by: Joe Clapis <jclapis@outlook.com>

* Support custom chain ids (Commit-Boost#429)

* Update README.md (Commit-Boost#436)

* Unify the CLI, PBS, and Signer Binaries into One (Commit-Boost#425)

Co-authored-by: Jason Vranek <jasonvranek@gmail.com>

Closes Commit-Boost#430, Commit-Boost#431, Commit-Boost#432

* add get_header auction winner log (Commit-Boost#443)

* Sigp audit fixes (Commit-Boost#438)

Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>
Co-authored-by: Joe Clapis <jclapis@outlook.com>
Co-authored-by: eltitanb <lorenzo@gattaca.com>
Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>

* fix deps from cherrypicking

* Update release.yml to work with unified binaries Commit-Boost#415

---------

Co-authored-by: Joe Clapis <jclapis@outlook.com>
Co-authored-by: iurii-ssv <183610124+iurii-ssv@users.noreply.github.com>
Co-authored-by: Sergey Yakovlev <selfuryon@pm.me>
Co-authored-by: Dominik Niedbała <dominikniedbala18@gmail.com>
Co-authored-by: ninaiiad <nina@gattaca.com>
Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>
Co-authored-by: eltitanb <lorenzo@gattaca.com>
Co-authored-by: ltitanb <163874448+ltitanb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove helder in chain info

3 participants